Build with Vite #1045
Build with Vite #1045
Conversation
| if (graphHopperResponseFile) { | ||
| nock('https://graphhopper.com') | ||
| // Turn on log in order to view nock request URLs. | ||
| .log(console.log) |
There was a problem hiding this comment.
nock.log no longer exists in recent node versions.
| "mastarm": "^5.3.1", | ||
| "md5-file": "^4.0.0", | ||
| "nock": "^9.0.14", | ||
| "nock": "^13.5.6", |
There was a problem hiding this comment.
Nock 14+ require adding other mocks that are currently missing. Lmk is that's worth it in this PR.
There was a problem hiding this comment.
Keeping this component around in this PR, although it is not clear how it works.
|
@miles-grant-ibigroup How do you make docker use this branch's version of dockerfile for e2e tests? |
Here is the culprit: datatools-ui/__tests__/e2e/Dockerfile Line 2 in a5e48da That image that lives on amazon is using Node 14. If you look at what the container is doing I'm sure there is a way to avoid using the custom container. I think it just reduces the amount of time the e2e tests take to run I believe that all this custom image does is have puppeteer pre-installed and pre-configured to run in a headless environment |
This reverts commit eea1536.
Checklist
devbefore they can be merged tomaster)Description
This PR replaces mastarm with Vite as the build system (for dev and production). Other parts involving mastarm remain unchanged.
mastarm buildormastarm deployUseful commands:
env YAML_CONFIG=<path-to-frontend>/env.yml yarn startenv YAML_CONFIG=<path-to-frontend>/env.yml yarn build